Skip to content

Conversation

@Dantemss
Copy link
Member

@Dantemss Dantemss commented Mar 20, 2025

https://openstax.atlassian.net/browse/CORE-783

  • Copied help menu from Assignments
  • Story, specs
  • Fixed ladle navbar in SidebarNav stories

@Dantemss Dantemss requested a review from jivey March 20, 2025 23:28
@Dantemss Dantemss self-assigned this Mar 20, 2025
@Dantemss Dantemss requested a review from bethshook March 21, 2025 15:21
@Dantemss Dantemss changed the title Help menu CORE-783 Help menu Mar 21, 2025
Copy link
Member

@jivey jivey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these styles came from assignments, so maybe this is expected and it renders fine there, but I was surprised to see the Back button floating in the middle. Just making sure this is expected

image

};

const IframeWrapper = styled.div`
background-color: #F5F5F5;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is neutralBright in the color palette

display: none;
#ladle-root {
position: absolute;
right: 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is probably better than the pseudo-preview mode

button {
height: 3rem;
background-color: white;
border: 1px solid #D5D5D5;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might want to use the color palette here too

@Dantemss
Copy link
Member Author

@jivey I think the back button being weird is really a side-effect of the shenanigans I had to do specifically in ladle to have the ladle sidebar still work in body portal mode. Normally the contact us form should occupy the whole screen, but here it's getting restricted to the side, so the button looks weird.

@Dantemss
Copy link
Member Author

Dantemss commented Mar 25, 2025

It seems that instead of pushing ladle-root to the side I can set position: fixed, top:0, width: 100% on the navbar. This seems to make the back button look correct.

@Dantemss Dantemss merged commit 1050ecf into main Mar 25, 2025
3 checks passed
@Dantemss Dantemss deleted the help-menu branch March 25, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants